fix: environment edit modal save#7371
Merged
jackkav merged 2 commits intoKong:developfrom May 14, 2024
Merged
Conversation
Contributor
|
Thanks for the PR, nice job on the playwright test! |
jackkav
approved these changes
May 14, 2024
6881712 to
f5d9aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an improvement of #7330
Background
For environment override modifications, the current behavior did not persist these changes consistently. This is not consistent with the expected behavior of persisting changes as the user closes and re-opens the modal after submitting some change.
This was caused by two issues:
Changes
useRequestGroupPatcherCloses #5612