Skip to content

fixes codemirror measure issue#7391

Merged
filfreire merged 1 commit intodevelopfrom
feature/ins-3831-the-url-bar-value-is-currently-not-showing-unless-we-click
May 10, 2024
Merged

fixes codemirror measure issue#7391
filfreire merged 1 commit intodevelopfrom
feature/ins-3831-the-url-bar-value-is-currently-not-showing-unless-we-click

Conversation

@jackkav
Copy link
Contributor

@jackkav jackkav commented May 9, 2024

react-resizable-panels are interacting with codemirror

codemirror has a css class called codemirror-measure used to estimate the pixel height of the parent element in order to render the content.
For some odd reason setting a default width on the panel causes the codemirror-measure class to report the wrong size and cause the code mirror to render the content below and behind the on-line-input.
This approach is a fix but obviously has some consequences.

@jackkav jackkav requested a review from gatzjames May 10, 2024 07:46
@filfreire filfreire force-pushed the feature/ins-3831-the-url-bar-value-is-currently-not-showing-unless-we-click branch from 2f95997 to 4c9355f Compare May 10, 2024 10:39
@filfreire filfreire enabled auto-merge (squash) May 10, 2024 10:39
@filfreire filfreire merged commit 219158f into develop May 10, 2024
@filfreire filfreire deleted the feature/ins-3831-the-url-bar-value-is-currently-not-showing-unless-we-click branch May 10, 2024 10:50
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants