Conversation
jackkav
reviewed
May 21, 2024
Contributor
There was a problem hiding this comment.
Has this been tested? Seems like a sensitive code path. @gatzjames seems like the existing e2e test isn't covering this case correctly
gatzjames
approved these changes
Jul 12, 2024
gatzjames
force-pushed
the
fix/migrate-redirect
branch
from
b424463 to
802b5ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shouldMigrateProjectUnderOrganizationis an async function, so we need to addawait