Skip to content

fix: project with null remoteId don't need to be updated #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatzjames merged 2 commits into from
May 29, 2024
Merged

fix: project with null remoteId don't need to be updated #7464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4d57bc
fix: project with null remoteId don't need to be updated
CurryYangxx May 29, 2024
be0ca07
fix: add detailed comments
CurryYangxx May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/insomnia/src/ui/routes/project.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,13 @@ async function syncTeamProjects({
const removedRemoteProjects = await database.find<Project>(models.project.type, {
// filter by this organization so no legacy data can be accidentally removed, because legacy had null parentId
parentId: organizationId,
// Remote ID is not in the list of remote projects
remoteId: { $nin: teamProjects.map(p => p.id) },
// Remote ID is not in the list of remote projects.
// add `$ne: null` condition because if remoteId is already null, we dont need to remove it again.
// nedb use append-only format, all updates and deletes actually result in lines added
remoteId: {
$nin: teamProjects.map(p => p.id),
$ne: null,
},
});

await Promise.all(removedRemoteProjects.map(async prj => {
Expand Down