feat(Key-Value Editor): Improve accessibility and make the items re-orderable#7465
Merged
gatzjames merged 9 commits intoKong:developfrom Jun 5, 2024
Conversation
gatzjames
force-pushed
the
feature/ins-3868-add-back-the-ability-to-reorder-query-parameters
branch
3 times, most recently
from
e11fae1 to
4d9fa98
Compare
gatzjames
force-pushed
the
feature/ins-3868-add-back-the-ability-to-reorder-query-parameters
branch
3 times, most recently
from
18ff492 to
f9cd7aa
Compare
CurryYangxx
reviewed
Jun 5, 2024
packages/insomnia/src/ui/components/editors/request-headers-editor.tsx
Outdated
Show resolved
Hide resolved
gatzjames
force-pushed
the
feature/ins-3868-add-back-the-ability-to-reorder-query-parameters
branch
from
f9cd7aa to
c083acc
Compare
CurryYangxx
approved these changes
Jun 5, 2024
gatzjames
force-pushed
the
feature/ins-3868-add-back-the-ability-to-reorder-query-parameters
branch
from
5a4c436 to
0ca0052
Compare
gatzjames
deleted the
feature/ins-3868-add-back-the-ability-to-reorder-query-parameters
branch
saisatishkarra
pushed a commit
that referenced
this pull request
Jun 5, 2024
…rderable (#7465) * remove unused components * make read-only editors display nunjucks * graphql toolbar css * re-orderable key value editor * move onChange to event handlers * remove unused test * fix delete all/add updates * clean up logs * remove callbacks
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
…rderable (Kong#7465) * remove unused components * make read-only editors display nunjucks * graphql toolbar css * re-orderable key value editor * move onChange to event handlers * remove unused test * fix delete all/add updates * clean up logs * remove callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights:
Extras:
TODO:
Closes #5686