Skip to content

chore(Database types): Infer query params from database model#7512

Merged
jackkav merged 1 commit intoKong:developfrom
gatzjames:chore/db-types
Jun 7, 2024
Merged

chore(Database types): Infer query params from database model#7512
jackkav merged 1 commit intoKong:developfrom
gatzjames:chore/db-types

Conversation

@gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Jun 7, 2024

Highlights:

  • Adds a generic type to the database Query type. This allows us to safely query specific properties of any database model
  • Removes a bunch of ts-expect-error

@gatzjames gatzjames self-assigned this Jun 7, 2024
@gatzjames gatzjames requested a review from a team June 7, 2024 09:16
@gatzjames gatzjames enabled auto-merge (squash) June 7, 2024 10:27
@jackkav jackkav disabled auto-merge June 7, 2024 10:32
@jackkav jackkav merged commit 48eea15 into Kong:develop Jun 7, 2024
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
@gatzjames @stefancruz
improve database types to allow for querying per model fields (Kong#7512
cd1b8fb 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackkav jackkav jackkav approved these changes

+1 more reviewer

@filfreire filfreire filfreire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gatzjames gatzjames

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gatzjames @jackkav @filfreire