spike: proxy error on login [INS-4009]#7546
Merged
filfreire merged 6 commits intoKong:developfrom Jun 17, 2024
Merged
Conversation
Contributor
|
Is the preferences panel visible during login in order for a user to respond to your message? And is insomnia proxy config the cause of this error? Could it also be system proxy? |
Contributor
Author
Preferences is visible by doing the keyboard shortcut - not good UX, perhaps a "link" that would open preferences would also help. It can be either Insomnia proxy config and system proxy. |
Contributor
|
Perhaps indicate the hot key and generalise the wording to compensate |
Contributor
Author
|
@jackkav added preferences button and changed the error text a bit: |
jackkav
reviewed
Jun 14, 2024
jackkav
approved these changes
Jun 15, 2024
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
* fix: proxy error on login [INS-4009] * add preferences button * change data-testid for settings in auth authorize * Update packages/insomnia/src/ui/routes/auth.authorize.tsx Co-authored-by: Jack Kavanagh <jackkav@gmail.com> * Update auth.authorize.tsx * Update auth.authorize.tsx --------- Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes, barely, INS-4009. hic sunt dracones
Some users will see the "Failed to Fetch" due to having a Proxy configured, either on their machines or on Insomnia Settings, which doesn't seem to work well with InsomniaFetch during login or the whoami call. One extra hypothesis, untested, is that some users might be facing problems due to CORS, not sure yet
I've tried capturing exception similar to
ERR_PROXY_CONNECTION_FAILEDbut it gets swallowed by sentry instrumentation onfetch()function, regardless of what failure happens of fetch, it's swallowed with aTypeError: Failed to fetch.By the time we try to capture a http status code, we always get the above exception.
Tried a handful of things to circunvent this but nothing seemed to work, e.g.
Other related findings:
Useful steps to repro/test
localhost:8005that will force the exceptionfetch()by hand to whoami endpoint or a url that doesn't exist.