Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| workingDir?: string, | ||
| ): Promise<string> { | ||
| const outputPath = path.isAbsolute(output) ? output : path.join(workingDir || process.cwd(), output); | ||
| const outputPath = path.isAbsolute(output) ? output : path.resolve(workingDir || process.cwd(), output); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal
| workingDir?: string, | ||
| ): Promise<string> { | ||
| const outputPath = path.isAbsolute(output) ? output : path.join(workingDir || process.cwd(), output); | ||
| const outputPath = path.isAbsolute(output) ? output : path.resolve(workingDir || process.cwd(), output); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal
jackkav
force-pushed
the
inso-fourth-pass
branch
from
4abcf96 to
beb6472
Compare
jackkav
force-pushed
the
inso-fourth-pass
branch
from
beb6472 to
a9bd89a
Compare
filfreire
approved these changes
Jun 27, 2024
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
* upgrade cosmiconfig * remove one layer of indirection * more indirection * upgrade commander * fix tests * remove unusedExitoverride * flatten * inline * flatten config * fix test * docs * flatten logging * dont default to script * fix test docs and config search * refactor exportSpec * fixed test
CurryYangxx
pushed a commit
that referenced
this pull request
Jul 5, 2024
* upgrade cosmiconfig * remove one layer of indirection * more indirection * upgrade commander * fix tests * remove unusedExitoverride * flatten * inline * flatten config * fix test * docs * flatten logging * dont default to script * fix test docs and config search * refactor exportSpec * fixed test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref INS-4021