Skip to content

fix oauth2 folder fetch#7649

Merged
jackkav merged 1 commit intoKong:developfrom
jackkav:fix-7596
Jul 3, 2024
Merged

fix oauth2 folder fetch#7649
jackkav merged 1 commit intoKong:developfrom
jackkav:fix-7596

Conversation

@jackkav
Copy link
Contributor

@jackkav jackkav commented Jul 3, 2024

fix #7596

motivation: the oauth2 dialog in the folder allows you to fetch with the given config in order to test it, but it will also generate a token object. However in a folder this code path wasn't working because it was only written for requests not folders.

Approaches:

  • remove the token fetcher from the folder dialog
  • fix the token fetcher in folders

future work:

  • add a ux to indicate tokens exist as child objects of requests and groups
  • point the request at the folder token rather than regenerating a token in the request by overwriting the request auth object.

@jackkav jackkav merged commit 9384139 into Kong:develop Jul 3, 2024
@jackkav jackkav deleted the fix-7596 branch July 3, 2024 08:35
@sentry
Copy link

sentry bot commented Jul 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: failed to find request invariant(src/utils/invariant) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Folder OAuth 2.0 failed to fetch token

2 participants