fix: reduce uncessary navigate when switching requests and tests#7748
Merged
CurryYangxx merged 4 commits intodevelopfrom Jul 24, 2024
Merged
fix: reduce uncessary navigate when switching requests and tests#7748CurryYangxx merged 4 commits intodevelopfrom
CurryYangxx merged 4 commits intodevelopfrom
Conversation
jackkav
reviewed
Jul 23, 2024
Comment on lines
+89
to
+93
| const [apiSpec, workspace, workspaceMeta] = await Promise.all([ | ||
| models.apiSpec.getByParentId(workspaceId), | ||
| models.workspace.getById(workspaceId), | ||
| models.workspaceMeta.getByParentId(workspaceId), | ||
| ]); |
Contributor
There was a problem hiding this comment.
this seems a one off / out of scope / unnecessary optimization.
Member
Author
There was a problem hiding this comment.
Sorry, already remove from this pr. Let us focus on the stuff metioned in description 😄.
CurryYangxx
force-pushed
the
fix/switch-request
branch
from
5da25bb to
308be7f
Compare
CurryYangxx
force-pushed
the
fix/switch-request
branch
from
79ce332 to
6f327ac
Compare
ihexxa
previously approved these changes
Jul 24, 2024
gatzjames
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already called navigate in GridList onAction or onSelectionChange callback. So we don't need the navigate in onSingleClick callback.
insomnia/packages/insomnia/src/ui/routes/debug.tsx
Line 1024 in c1cd04f
Navigating to the same URL as the current URL will cause uncessary loader revalidation.