Skip to content

fix(GraphQL Editor): make inputValueDeprecation optional and change variable mode to json#7779

Merged
gatzjames merged 1 commit intoKong:developfrom
gatzjames:fix/graphql-variables
Jul 30, 2024
Merged

fix(GraphQL Editor): make inputValueDeprecation optional and change variable mode to json#7779
gatzjames merged 1 commit intoKong:developfrom
gatzjames:fix/graphql-variables

Conversation

@gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Jul 30, 2024

Highlights:

  • Changes the variables mode to json to fix an issue where variables require a leading comma and are not used in the end.
  • Makes the inputValueDeprecation optional since there are introspection APIs that do not support it and fetching the schema fails on them

Closes INS-4229

@gatzjames gatzjames self-assigned this Jul 30, 2024
@gatzjames gatzjames requested a review from a team July 30, 2024 10:01
@gatzjames gatzjames enabled auto-merge (squash) July 30, 2024 10:11
@gatzjames gatzjames merged commit 5ff69d6 into Kong:develop Jul 30, 2024
@gatzjames gatzjames deleted the fix/graphql-variables branch July 30, 2024 10:23
@sentry
Copy link

sentry bot commented Aug 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: Syntax Error: Unexpected Name "curl". (1:1) > 1 | curl -kv POST (rib/graphql --header 'Auth... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants