Skip to content

fix: persist cookies from response together with ones from after-response script#7819

Merged
ihexxa merged 2 commits intodevelopfrom
fix/persist-script-cookies
Aug 23, 2024
Merged

fix: persist cookies from response together with ones from after-response script#7819
ihexxa merged 2 commits intodevelopfrom
fix/persist-script-cookies

Conversation

@ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Aug 7, 2024

Background

Cookies from response are persisted. When after-response script is enabled, it will persisted in savePatchesMadeByScript but it doesn't include cookies from response.

Fixes #7808 INS-4264

Changes

  • cookies from response should also persisted together with ones from after-response

@ihexxa ihexxa self-assigned this Aug 7, 2024
@ihexxa ihexxa marked this pull request as draft August 7, 2024 08:56
@ihexxa ihexxa changed the title fix: cookies from response should also persisted together with ones from after-response fix: persist cookies from response together with ones from after-response script Aug 7, 2024
@notjaywu notjaywu requested a review from CurryYangxx August 15, 2024 02:51
@notjaywu notjaywu force-pushed the fix/persist-script-cookies branch from d37ba2e to 90522d7 Compare August 23, 2024 02:37
@ihexxa ihexxa marked this pull request as ready for review August 23, 2024 03:17
@ihexxa ihexxa enabled auto-merge (squash) August 23, 2024 03:19
@ihexxa ihexxa force-pushed the fix/persist-script-cookies branch from c8d0dc8 to 6d42384 Compare August 23, 2024 03:41
@ihexxa ihexxa merged commit be8a04c into develop Aug 23, 2024
@ihexxa ihexxa deleted the fix/persist-script-cookies branch August 23, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cookies do not get saved when there is any After-Response script

2 participants