Skip to content

fix(runner): some minor fixes and improvements#7900

Merged
ihexxa merged 4 commits intodevelopfrom
fix/runner-cleanup-1
Sep 4, 2024
Merged

fix(runner): some minor fixes and improvements#7900
ihexxa merged 4 commits intodevelopfrom
fix/runner-cleanup-1

Conversation

@ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Sep 2, 2024

Changes

  • Settings' layout sometimes wrapped.
  • Save last settings (iteration, delay, and data)
  • Hide the alert modal and display error message in the console

Ref: INS-4366

@ihexxa ihexxa self-assigned this Sep 2, 2024
@ihexxa ihexxa marked this pull request as draft September 2, 2024 09:39
@ihexxa ihexxa marked this pull request as ready for review September 3, 2024 02:09
@ihexxa ihexxa force-pushed the fix/runner-cleanup-1 branch from c396959 to 2390c03 Compare September 3, 2024 02:10
jackkav
jackkav previously approved these changes Sep 3, 2024
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to use for var i loops. If you have some more energy for it I'd like you to take another pass, if not you can merge it but it will be inconsistent.
In one of the review comments you said you have plans to refactor this soon, in future please link to the ticket or the work you propose to refactor it as part of. The idea here is that when we scope things out we aren't dismissing the comment entirely just pushing it into a different PR.

TLDR: use functional style where possible, unless processing a list thousands of items.

@ihexxa
Copy link
Contributor Author

ihexxa commented Sep 4, 2024

Update: The "reset" button is removed according to the request.
And the ticket for tracking: INS-4374

@ihexxa ihexxa force-pushed the fix/runner-cleanup-1 branch 2 times, most recently from c6e2776 to ee47eb5 Compare September 4, 2024 09:36
@ihexxa ihexxa force-pushed the fix/runner-cleanup-1 branch from ee47eb5 to dcea269 Compare September 4, 2024 09:58
@ihexxa ihexxa merged commit af3ad5b into develop Sep 4, 2024
@ihexxa ihexxa deleted the fix/runner-cleanup-1 branch September 4, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants