fix(runner): some minor fixes and improvements#7900
Merged
Conversation
jackkav
reviewed
Sep 2, 2024
jackkav
reviewed
Sep 2, 2024
c396959 to
2390c03
Compare
jackkav
previously approved these changes
Sep 3, 2024
Contributor
There was a problem hiding this comment.
I'd prefer not to use for var i loops. If you have some more energy for it I'd like you to take another pass, if not you can merge it but it will be inconsistent.
In one of the review comments you said you have plans to refactor this soon, in future please link to the ticket or the work you propose to refactor it as part of. The idea here is that when we scope things out we aren't dismissing the comment entirely just pushing it into a different PR.
TLDR: use functional style where possible, unless processing a list thousands of items.
Contributor
Author
|
Update: The "reset" button is removed according to the request. |
c6e2776 to
ee47eb5
Compare
ee47eb5 to
dcea269
Compare
CurryYangxx
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Ref: INS-4366