Fix duplicate file cause application error in collection view UI#7928
Merged
Fix duplicate file cause application error in collection view UI#7928
Conversation
CurryYangxx
previously approved these changes
Sep 9, 2024
Member
|
May be we need a smoke test for this duplicate entrance. @yaoweiprc |
jackkav
previously approved these changes
Sep 9, 2024
filfreire
previously approved these changes
Sep 9, 2024
cwangsmv
dismissed stale reviews from filfreire, jackkav, and CurryYangxx
via
2486c71
CurryYangxx
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Screen.Recording.2024-09-09.at.11.59.27.mp4
Cause
Race condition.
Current page loader function in router will trigger due to create action in database.
Meanwhile, new page loader function in router will also be triggered. So when new open is rendering, the loaderData will be overridden by old page loader function which cause this issue.
Change
Use old way of redirect function in duplicateWorkspaceAction