Open
Conversation
✅ Circular References ReportGenerated at: 2026-01-19T09:18:16.612Z Summary
Click to view all circular references in PR (167)Click to view all circular references in base branch (167)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to replace Node.js-specific node:url package with the standard Web URL API, eliminating Node.js dependencies in several utility files.
Key changes:
- Replace
urlParse()andurlFormat()fromnode:urlwith standardURLconstructor andtoString()method - Add proper error handling with try-catch blocks for URL parsing
- Update property access patterns (e.g.,
parsedUrl.query→parsedUrl.search.slice(1))
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/utils/url/querystring.ts | Refactored smartEncodeUrl() to use standard URL API instead of node:url's parse/format functions, with added error handling for invalid URLs |
| packages/insomnia/src/network/url-matches-cert-host.ts | Replaced urlParse() with URL constructor for parsing request URLs and certificate hosts, with try-catch error handling |
| packages/insomnia/src/network/is-url-matched-in-no-proxy-rule.ts | Replaced urlParse() with URL constructor for parsing URLs in proxy rule matching logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cwangsmv
previously approved these changes
Dec 30, 2025
jackkav
previously approved these changes
Jan 6, 2026
CurryYangxx
previously approved these changes
Jan 19, 2026
ce453b7
jackkav
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Replace node:url package with URL, so that these files can get rid of Node.js dependencies.
INS-1819