Fixed concatKeepingSchema turning ColumnGroups into DataColumns#1764
Merged
Fixed concatKeepingSchema turning ColumnGroups into DataColumns#1764
Conversation
Jolanrensen
approved these changes
Mar 23, 2026
Collaborator
Jolanrensen
left a comment
Jolanrensen
left a comment
There was a problem hiding this comment.
ah, I see, it would probably indeed be better to simply call .concat() and not have to fix the logic in two places. But let's await #1761 indeed. For now it's okay :)
koperagen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1763
arrow cannot yet read framecolumns, so fix only for ColumnGroup. Maybe in the future we should remove code duplication, but let's wait for benchmark result first. For now i'd like to keep this optimized version