Repository navigation
fix(desktop): keep the model picker card on screen and put accounts side by side - #3450
Merged
Merged
Conversation
…ide by side The effort step keeps its back row fixed and scrolls only the list under it, with a fade at the foot when it runs on. Accounts are a row of chips under the effort list; left and right walk the chips, up and down stay on the efforts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The model picker's second step (Effort, then Account) was one tall column that could be cut off at the top or bottom depending on where the card opened. Now the back row stays fixed and only the list under it scrolls, with a fade at the foot when it runs on. Accounts are a segmented row of chips (user icon and name, the selected one filled, a signed-out one faded with a tooltip, all disabled while a turn runs) that wraps for many accounts.
Keyboard: up/down move through the efforts and treat the chip row as one stop; left/right walk the chips, and left on the first chip (or Backspace) still goes back.
Changelog
The model picker card now fits inside the window, and accounts show as side-by-side chips under the effort list.
Testing
bun run checkinapps/desktop(typecheck, lint, unit tests incl. newmoveChiptests, build). Not checked visually in the mock window.Closes #3449