Repository navigation
fix(desktop): make Check all match checking each harness on its own - #3451
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Check all marked harnesses as failing that pass when checked one by one. It started every check at once, and every answer replaced the whole harness snapshot, so a late, older answer brought back a stale detection.
refreshHarnessesandharnessCall).account/checkthat re-detects every harness (one plan/Keychain read), then starts the harnesses two at a time to list their models. A harness already being checked is joined.Changelog
Check all in Settings > Harnesses now ends with the same results as pressing Check on each harness, and shows its progress.
Testing
bun run checkinapps/desktop(typecheck, lint, tests, build).harnessChecks.test.ts: Check all ends in the same per-card results as checking each alone; oneaccount/checkwith every id; at most two model listings at once; joining a running check; a delayed older snapshot does not replace a newer one (fails without the guard).Closes #3448