Repository navigation
fix(desktop): list a delegate in the machine it runs on and read its answer as plain text - #3452
Merged
Merged
Conversation
…answer as plain text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A delegate started on a paired machine from another computer was nested under its parent here, and the machine's Devices view skips nested threads, so that machine listed none of its own delegates (#3441). It now keeps a row in the machine it runs on, with a
from <thread> on <machine>hint that opens the parent; it is still nested under the parent. An empty machine says "No threads on this machine yet." with a New thread button that starts one there. The rule iscrossMachineDelegatesinsrc/state/sidebarGroups.ts.For #3440 this PR changes how a delegate's answer reads, not why it was marked Failed:
Link.error), instead of the reply drawn in the error colour.Not fixed: why the remote Claude Code delegate's link settled as
failedafter a full answer. A failed link comes only from the prompt request rejecting (runPromptinsrc/state/store.tstreats any rejection, including a dropped machine connection, as a failed turn). I could not reproduce or confirm the cause from the code alone, so #3440 stays open.Changelog
A delegate running on another machine now appears in that machine's thread list, and delegate rows show a plain-text preview of the answer.
Testing
bun run checkinapps/desktop: typecheck, lint, 2031 tests, build.crossMachineDelegateswith a remote delegate whose parent is local (sidebarGroups.test.ts), andanswerPreview(answerPreview.test.ts).Closes #3441
Refs #3440