Repository navigation
fix(desktop): say a machine's route hint once and leave this computer out of Machines found - #3453
Merged
Merged
Conversation
… out of Machines found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes in Settings › Machines.
machineLineappended it to the route line and the row drew it again on its own line.machineLinenow returns the route only; the row's own hint line is the one place it shows.machines_discovernow leaves out a record whose gateway id is this computer's, or one of whose addresses is bound on this computer's interfaces on its gateway port (read fromremote/registration.json, else 17879).Changelog
Settings › Machines says a machine's route problem once and no longer lists this computer under Machines found.
Testing
bun run checkinapps/desktop; new render testsrc/ui/MachinesPage.test.tsxasserts the hint appears once.cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test machines::tests::this_computerinapps/desktop/src-tauri(covers the gateway-id and own-address matches).Closes #3433
Closes #3432