Skip to content

fix(desktop): say a machine's route hint once and leave this computer out of Machines found - #3453

Merged
LHagfoss merged 1 commit into
mainfrom
fix/desktop-machines-page-duplicates
Nov 11, 2026
Merged

LHagfoss merged 1 commit into
mainfrom
fix/desktop-machines-page-duplicates

Conversation

@LHagfoss

Copy link
Copy Markdown
Owner

What

Two fixes in Settings › Machines.

  • A connected machine's route hint (for example "Not reachable over the VPN …") was drawn twice: machineLine appended it to the route line and the row drew it again on its own line. machineLine now returns the route only; the row's own hint line is the one place it shows.
  • Machines found listed this computer. Bonjour hears the gateway this computer runs too. machines_discover now leaves out a record whose gateway id is this computer's, or one of whose addresses is bound on this computer's interfaces on its gateway port (read from remote/registration.json, else 17879).

Changelog

Settings › Machines says a machine's route problem once and no longer lists this computer under Machines found.

Testing

  • bun run check in apps/desktop; new render test src/ui/MachinesPage.test.tsx asserts the hint appears once.
  • cargo fmt --check, cargo clippy --all-targets -- -D warnings, cargo test machines::tests::this_computer in apps/desktop/src-tauri (covers the gateway-id and own-address matches).

Closes #3433
Closes #3432

@github-actions github-actions Bot added the fix A bug fix label Nov 11, 2026
@LHagfoss
LHagfoss merged commit 6629348 into main Nov 11, 2026
9 checks passed
@LHagfoss
LHagfoss deleted the fix/desktop-machines-page-duplicates branch November 11, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(desktop): say a machine's route hint once fix(desktop): leave this computer out of Machines found

1 participant