Repository navigation
fix(desktop): make the Run on chip idle at rest and show only the machine name - #3454
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The composer's Run on chip drew filled and bold at rest, so it looked pressed next to the folder chip, and its label ("Run on This computer") was the longest in the strip.
aria-label("Run on: ‹name›") and the tooltip keep the "Run on" wording.@max-lg/composer, icon-only under@max-sm/composer.selfName()(This Mac / This PC) in the chip and the menu, instead of "This computer".Monitor; the per-device icon from the device-settings issue does not exist yet.Changelog
The composer's Run on chip is idle at rest and shows just the machine's name.
Testing
bun run checkinapps/desktop.?machines=pairedbefore release.Closes #3444