Skip to content

Catch Erfa warnings#324

Merged
nabobalis merged 2 commits intoLM-SAL:mainfrom
wtbarnes:fix-erfa-warnings-finally
Dec 18, 2023
Merged

Catch Erfa warnings#324
nabobalis merged 2 commits intoLM-SAL:mainfrom
wtbarnes:fix-erfa-warnings-finally

Conversation

@wtbarnes
Copy link
Contributor

@wtbarnes wtbarnes commented Dec 8, 2023

Fixes #89

This PR catches the Erfa warnings that are raised when we convert the times from the error and degradation tables into UTC while making them astropy.time.Time objects.

@codecov
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e578cdf) 94.14% compared to head (e00317a) 94.09%.
Report is 2 commits behind head on main.

❗ Current head e00317a differs from pull request most recent head 406a473. Consider uploading reports for the commit 406a473 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   94.14%   94.09%   -0.05%     
==========================================
  Files          34       34              
  Lines        1178     1186       +8     
==========================================
+ Hits         1109     1116       +7     
- Misses         69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabobalis nabobalis marked this pull request as ready for review December 18, 2023 23:17
@nabobalis
Copy link
Member

Need to wait for any online tests to check.

@nabobalis nabobalis merged commit 0dbf5b9 into LM-SAL:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ErfaWarning and time-related AiapyUserWarning when running aiapy.calibration.degradation()

2 participants