Account for use of reference_date property#345
Merged
wtbarnes merged 7 commits intoLM-SAL:mainfrom Sep 24, 2024
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
nabobalis
approved these changes
Sep 23, 2024
nabobalis
approved these changes
Sep 23, 2024
Member
|
I will leave it up to you @wtbarnes when you want to merge. |
nabobalis
reviewed
Sep 24, 2024
nabobalis
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a few fixes to account for the existence of the new
reference_dateproperty onMapwhich is the correct date to use when constructing the coordinate frame and observer coordinate.This also now assumes the existence of the "T_OBS" key in the metadata since this is what is used for constructing
reference_datein the case of an AIA map.Since
reference_datewas only introduced in sunpy v6 we should decide how to go about using this property or just make the minimum version of sunpy v6.See also sunpy/sunpy#7810
Summary by Sourcery
Update the code to use the 'reference_date' property for constructing coordinate frames and observer coordinates, assuming the presence of 'T_OBS' in metadata for AIA maps. Adjust tests to reflect these changes and improve accuracy.
Bug Fixes:
Enhancements:
Tests: