Add Automatic-Module-Name to MANIFEST.MF#279
Merged
Michael Barker (mikeb01) merged 1 commit intoLMAX-Exchange:masterfrom Feb 10, 2020
matteodri:automatic-module-name
Merged
Add Automatic-Module-Name to MANIFEST.MF#279Michael Barker (mikeb01) merged 1 commit intoLMAX-Exchange:masterfrom matteodri:automatic-module-name
Michael Barker (mikeb01) merged 1 commit intoLMAX-Exchange:masterfrom
matteodri:automatic-module-name
Conversation
Adding Automatic-Module-Name in the manifest file makes the library usable as a Java automatic module preventing possible clashes of the name with other libraries.
|
Log4j 2 uses the disruptor. One of the goals of Log4j 2 3.x is to fully modularize all of our deliverables, so we need a released version that includes the automatic module name. When can we expect this in a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step in the process of modularizing the Disruptor JAR #234.
Adding Automatic-Module-Name in the manifest file makes the library usable as a Java automatic module without moving the library itself to Java 9 (or later) or creating a module-info.java.
This allows the Disruptor when loaded as an automatic module to get its name from the Automatic-Module-Name entry in MANIFEST.MF instead of being inferred from the filename. This second option is dangerous as filenames are far from being unique and stable.
This post explains the point of having an Automatic-Module-Name defined: http://branchandbound.net/blog/java/2017/12/automatic-module-name/