Adjust model rounding behavior to avoid a potential future mystery bug#8119
Open
rubiefawn wants to merge 1 commit intoLMMS:masterfrom
Open
Adjust model rounding behavior to avoid a potential future mystery bug#8119rubiefawn wants to merge 1 commit intoLMMS:masterfrom
rubiefawn wants to merge 1 commit intoLMMS:masterfrom
Conversation
11 tasks
Contributor
|
According to cppref:
So it seems there might be a behavior difference? |
Contributor
Author
|
There is. The behavior of |
And some other AutomatableModel::fittedValue() cleanup
239f5df to
aed8cb0
Compare
szeli1
approved these changes
Feb 6, 2026
Contributor
szeli1
left a comment
There was a problem hiding this comment.
I did not test this PR. I believe the code is functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutomatableModel::fittedValue()currently rounds values usingnearbyintf(), whose behavior depends on the current rounding mode. The default rounding mode appears to beFE_TONEARESTand is not ever changed in the entire LMMS codebase, sofittedValue()has been doing the same thing asround(), but with the added possibility of exploding if someone in the future decides to callfesetround()somewhere. This PR replacesnearbyintf()withround()to be more explicit about the behavior and eliminate the possibility of any spooky action resulting from different rounding modes.This PR also cleans up formatting and replaces two
ifs with a call toclamp().