Emit the playbackPositionJumped signal only when the active timeline jumps#8256
Merged
sakertooth merged 4 commits intoLMMS:masterfrom Feb 15, 2026
Merged
Conversation
…ible for the current play mode jumps
messmerd
reviewed
Feb 11, 2026
messmerd
reviewed
Feb 11, 2026
…t the other way around
regulus79
approved these changes
Feb 15, 2026
khoidauminh
pushed a commit
to khoidauminh/lmms
that referenced
this pull request
Feb 16, 2026
…e jumps (LMMS#8256) Only emit the playbackPositionJumped signal when the timeline responsible for the current play mode jumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7454 introduced a change where it aggregated all the timelines and emitted the
playbackPositionChangedsignal whenever any of the timelines move and the song is playing. This PR brings fourth a stronger guarantee: only emit theplaybackPositionChangedsignal when the song is playing and the timeline that jumped is responsible for the current play mode.Fixes #8251