Open
Conversation
Pull Request Test Coverage Report for Build 21349264080Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have ported out HMCode baryons into baryons module so it can be called in a similar manner to other baryon base modules.
To do so, I have used the existing hook to HMCode whihc is via camb call within the Cosmology object -- but wrapped in such a way that emulates the convention we want defined inside baryons_base.
One thing that was tricky is to ensure that the cosmology defined is always the cosmology object with camb BUT doing internal chekcs there is no baryonification already applied -- this is solved.
(side note: I can do the same for bacco and I think we should so that all of our baryon modules are called in the same way)
This PR adds:
utility/helper functions defined inside pyccl/baryons/mead20_hmcode/mead20_utils.py
pyccl/baryons/mead20.py which is the main script (kept pretty lightweight and readable) where BaryonsMead20 submodule is defined
corresponding unit tests
example notebooks (inside the pyccl/baryons/mead20_hmcode/ dir:
locally unit tests are passing, linting is healthy