added call to original operation#31
Merged
Pyrofab merged 1 commit intoLadysnake:masterfrom Oct 1, 2025
Merged
Conversation
The original onRemoved method must be called so that the LivingEntity class can handle the removal of attribute modifiers. This mixin is given as an example in the main readme of the library but, as is, breaks the default behaviour of effects with modifiers such as minecraft:health_boost and minecraft:absorption.
Pyrofab
approved these changes
Oct 1, 2025
Member
Pyrofab
left a comment
Pyrofab
left a comment
There was a problem hiding this comment.
Good catch, thank you ! It used to be an Inject, but I had to change it during an update and since it's only test code I never realized it was missing somoething.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original onRemoved method must be called so that the LivingEntity class can handle the removal of attribute modifiers.
This mixin is given as an example in the main readme of the library but, as is, breaks the default behaviour of effects with modifiers such as minecraft:health_boost and minecraft:absorption.
This is my first PR ever. I hope this is proper etiquette 👋