fix(source-generators): improve nested property fallback handling for CS8601 warnings

examples/DynamoMapper.FieldLevelOverride/Program.cs

@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using Amazon.DynamoDBv2.Model;
 using DynamoMapper.Runtime;
 

examples/DynamoMapper.MapperConstructor/Program.cs

@@ -1,4 +1,4 @@
-// See https://aka.ms/new-console-template for more information
+// See https://aka.ms/new-console-template for more information
 
 using System;
 

examples/DynamoMapper.Nested/MapperBasedNested.cs

@@ -8,16 +8,16 @@ namespace DynamoMapper.Nested;
 /// </summary>
 public record BlogPost
 {
-    public string Slug { get; set; }
-    public string Title { get; set; }
-    public Author Writer { get; set; }
+    public required string Slug { get; set; }
+    public required string Title { get; set; }
+    public required Author Writer { get; set; }
 }
 
 public record Author
 {
-    public string Handle { get; set; }
-    public string DisplayName { get; set; }
-    public string Bio { get; set; }
+    public required string Handle { get; set; }
+    public required string DisplayName { get; set; }
+    public required string Bio { get; set; }
 }
 
 // Author has its own mapper - BlogPostMapper will use this
@@ -35,4 +35,4 @@ public static partial class BlogPostMapper
     public static partial Dictionary<string, AttributeValue> ToItem(BlogPost source);
 
     public static partial BlogPost FromItem(Dictionary<string, AttributeValue> item);
-}
+}

examples/DynamoMapper.Nested/MultiLevelNested.cs

@@ -8,22 +8,22 @@ namespace DynamoMapper.Nested;
 /// </summary>
 public record Company
 {
-    public string Id { get; set; }
-    public string Name { get; set; }
-    public Department HeadOffice { get; set; }
+    public required string Id { get; set; }
+    public required string Name { get; set; }
+    public required Department HeadOffice { get; set; }
 }
 
 public record Department
 {
-    public string Code { get; set; }
-    public string Name { get; set; }
-    public Manager Lead { get; set; }
+    public required string Code { get; set; }
+    public required string Name { get; set; }
+    public required Manager Lead { get; set; }
 }
 
 public record Manager
 {
-    public string EmployeeId { get; set; }
-    public string FullName { get; set; }
+    public required string EmployeeId { get; set; }
+    public required string FullName { get; set; }
 }
 
 [DynamoMapper]
@@ -32,4 +32,4 @@ public static partial class CompanyMapper
     public static partial Dictionary<string, AttributeValue> ToItem(Company source);
 
     public static partial Company FromItem(Dictionary<string, AttributeValue> item);
-}
+}

examples/DynamoMapper.Nested/NestedCollectionDictionary.cs

@@ -8,15 +8,15 @@ namespace DynamoMapper.Nested;
 /// </summary>
 public record EmployeeDirectory
 {
-    public string DepartmentId { get; set; }
-    public string DepartmentName { get; set; }
-    public Dictionary<string, Employee> Employees { get; set; }
+    public required string DepartmentId { get; set; }
+    public required string DepartmentName { get; set; }
+    public required Dictionary<string, Employee> Employees { get; set; }
 }
 
 public record Employee
 {
-    public string Name { get; set; }
-    public string Title { get; set; }
+    public required string Name { get; set; }
+    public required string Title { get; set; }
     public decimal Salary { get; set; }
 }
 
@@ -26,4 +26,4 @@ public static partial class EmployeeDirectoryMapper
     public static partial Dictionary<string, AttributeValue> ToItem(EmployeeDirectory source);
 
     public static partial EmployeeDirectory FromItem(Dictionary<string, AttributeValue> item);
-}
+}

examples/DynamoMapper.Nested/NestedCollectionList.cs

@@ -8,14 +8,14 @@ namespace DynamoMapper.Nested;
 /// </summary>
 public record ShoppingCart
 {
-    public string CartId { get; set; }
-    public List<CartItem> Items { get; set; }
+    public required string CartId { get; set; }
+    public required List<CartItem> Items { get; set; }
 }
 
 public record CartItem
 {
-    public string ProductId { get; set; }
-    public string ProductName { get; set; }
+    public required string ProductId { get; set; }
+    public required string ProductName { get; set; }
     public int Quantity { get; set; }
     public decimal UnitPrice { get; set; }
 }
@@ -26,4 +26,4 @@ public static partial class ShoppingCartMapper
     public static partial Dictionary<string, AttributeValue> ToItem(ShoppingCart source);
 
     public static partial ShoppingCart FromItem(Dictionary<string, AttributeValue> item);
-}
+}

examples/DynamoMapper.Nested/NestedWithScalars.cs

@@ -8,8 +8,8 @@ namespace DynamoMapper.Nested;
 /// </summary>
 public record Invoice
 {
-    public string InvoiceNumber { get; set; }
-    public PaymentInfo Payment { get; set; }
+    public required string InvoiceNumber { get; set; }
+    public required PaymentInfo Payment { get; set; }
 }
 
 public record PaymentInfo
@@ -26,4 +26,4 @@ public static partial class InvoiceMapper
     public static partial Dictionary<string, AttributeValue> ToItem(Invoice source);
 
     public static partial Invoice FromItem(Dictionary<string, AttributeValue> item);
-}
+}

examples/DynamoMapper.Nested/NullableNested.cs

@@ -8,15 +8,15 @@ namespace DynamoMapper.Nested;
 /// </summary>
 public record Product
 {
-    public string Sku { get; set; }
-    public string Name { get; set; }
+    public required string Sku { get; set; }
+    public required string Name { get; set; }
     public Warranty? Warranty { get; set; }  // Nullable nested object
 }
 
 public record Warranty
 {
     public int DurationMonths { get; set; }
-    public string Provider { get; set; }
+    public required string Provider { get; set; }
 }
 
 [DynamoMapper]
@@ -25,4 +25,4 @@ public static partial class ProductMapper
     public static partial Dictionary<string, AttributeValue> ToItem(Product source);
 
     public static partial Product FromItem(Dictionary<string, AttributeValue> item);
-}
+}

examples/DynamoMapper.Nested/Order.cs

@@ -5,15 +5,15 @@ namespace DynamoMapper.Nested;
 
 public record Order
 {
-    public string Id { get; set; }
-    public Address ShippingAddress { get; set; }
+    public required string Id { get; set; }
+    public required Address ShippingAddress { get; set; }
 }
 
 public record Address
 {
-    public string Line1 { get; set; }
-    public string City { get; set; }
-    public string PostalCode { get; set; }
+    public required string Line1 { get; set; }
+    public required string City { get; set; }
+    public required string PostalCode { get; set; }
 }
 
 [DynamoMapper]

examples/DynamoMapper.Nested/Program.cs

@@ -63,7 +63,9 @@
 var productWithoutWarranty =
     new Product
     {
-        Sku = "CABLE-001", Name = "USB Cable", Warranty = null, // No warranty
+        Sku = "CABLE-001",
+        Name = "USB Cable",
+        Warranty = null, // No warranty
     };
 
 Console.WriteLine($"Product with warranty: {productWithWarranty}");
@@ -208,7 +210,9 @@
                 ["emp002"] =
                     new Employee
                     {
-                        Name = "Bob Smith", Title = "Junior Engineer", Salary = 75000m,
+                        Name = "Bob Smith",
+                        Title = "Junior Engineer",
+                        Salary = 75000m,
                     },
             },
     };

src/LayeredCraft.DynamoMapper.Generators/ConstructorMapping/ConstructorSelector.cs

@@ -60,8 +60,12 @@ GeneratorContext context
         if (!hasParameterlessConstructor)
         {
             // NO parameterless constructor → MUST use a non-parameterless constructor
-            var selectedConstructor = SelectConstructorWithMostParameters(constructors);
-            return AnalyzeConstructorSelection(selectedConstructor, properties, false, context);
+            return AnalyzeConstructorSelection(
+                SelectConstructorWithMostParameters(constructors),
+                properties,
+                false,
+                context
+            );
         }
 
         // PRIORITY 3: Parameterless constructor exists - check deserialization accessibility
@@ -73,8 +77,12 @@ GeneratorContext context
         }
 
         // PRIORITY 4: Has read-only properties - use constructor with most parameters
-        var selectedConstructor2 = SelectConstructorWithMostParameters(constructors);
-        return AnalyzeConstructorSelection(selectedConstructor2, properties, false, context);
+        return AnalyzeConstructorSelection(
+            SelectConstructorWithMostParameters(constructors),
+            properties,
+            false,
+            context
+        );
     }
 
     /// <summary>

src/LayeredCraft.DynamoMapper.Generators/MapperReferenceExtractor.cs

@@ -114,4 +114,4 @@ WellKnownTypes.WellKnownTypes wellKnownTypes
             namedType.TypeArguments[1],
             WellKnownType.Amazon_DynamoDBv2_Model_AttributeValue
         );
-}
+}

src/LayeredCraft.DynamoMapper.Generators/Models/MapperReference.cs

@@ -12,4 +12,4 @@ internal sealed record MapperReference(
     string MapperFullyQualifiedName,
     bool HasToItemMethod,
     bool HasFromItemMethod
-);
+);

src/LayeredCraft.DynamoMapper.Generators/Models/MapperRegistry.cs

@@ -43,4 +43,4 @@ internal bool HasMapper(ITypeSymbol modelTypeSymbol)
         );
         return ModelToMapper.ContainsKey(fullyQualifiedName);
     }
-}
+}

src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/MemberAnalyzer.cs

@@ -79,9 +79,9 @@ internal static PropertyNullabilityInfo AnalyzeNullability(ITypeSymbol type)
         var isNullableType =
             type
                 is INamedTypeSymbol
-                {
-                    OriginalDefinition.SpecialType: SpecialType.System_Nullable_T,
-                }
+            {
+                OriginalDefinition.SpecialType: SpecialType.System_Nullable_T,
+            }
             || (isReferenceType && annotation == NullableAnnotation.Annotated);
 
         return new PropertyNullabilityInfo(isNullableType, isReferenceType, annotation);

src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/Models/CollectionInfo.cs

@@ -51,4 +51,4 @@ internal enum CollectionCategory
     /// Set-like collections (HashSet<T>, ISet<T>) → DynamoKind.SS/NS/BS based on element type
     /// </summary>
     Set
-}
+}

src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/Models/NestedMappingInfo.cs

@@ -47,4 +47,4 @@ internal sealed record NestedPropertySpec(
     string DynamoKey,
     TypeMappingStrategy? Strategy,
     NestedMappingInfo? NestedMapping = null
-);
+);

src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/NestedAnalysisContext.cs

@@ -126,4 +126,4 @@ internal bool HasOverridesForCurrentPath()
     /// <returns>A new nested analysis context.</returns>
     internal static NestedAnalysisContext Create(GeneratorContext context, MapperRegistry registry) =>
         new(context, registry, ImmutableHashSet<string>.Empty);
-}
+}