Skip to content

fix(lazurio): a fresh auto send queues during setup; record the v0.1.9 check - #198

Merged
agentrozjedemeai merged 1 commit into
mainfrom
lazurio/v0.1.9-audit-records
Nov 13, 2026
Merged

agentrozjedemeai merged 1 commit into
mainfrom
lazurio/v0.1.9-audit-records

Conversation

@immakermatty

Copy link
Copy Markdown

Status: ready for review

Problem

The independent v0.1.9 check in #185 (comment 6863502146) listed points 3 to 7 besides the two blockers fixed in #196 and #197:

  1. Row 30: planComposerTurn turned a fresh-session send during setup into a queue only for steer and restart, so a fresh auto kept auto, while the runbook said a fresh session queues. The row's test sent only a fresh steer.
  2. Row 10, decision A2: the only test of full-resolution snapshots is a CDP test the fork CI skips (environmentBrowserConnection.test.ts:57), and nothing pinned environmentBrowserConnection.ts:187.
  3. Row 22: the v0.1.9 context-budget figures and the Codex features list check were not recorded.
  4. Row 4: upstream's t3 install hint names upstream's installer with no decision; row 5 said no contract seam changed on v0.1.9.
  5. Row 16's commit lost a # line in the cherry-pick, row 28's file list missed buddySurfaceTimeline.test.ts, the overlay spec still described only the 1280 px cap, and row 30's /goal line references were stale.

Change

  • apps/web/src/components/ChatView.logic.ts: during setup, a fresh-session send queues for every dispatch mode; a plain auto still stays auto (the server steers it in, Buddy: a follow-up sent while a cold session's turn starts becomes a second turn, not a steer #170). ChatView.logic.test.ts sends a fresh auto and a fresh steer during setup and expects a queue.
  • scripts/lazurio-release-contract.test.mjs: the row 30 pin follows the new condition; the browser-seams test pins fullScreenshot in environmentBrowserConnection.ts and full: input.fullScreenshot ? full : undefined in ServerBrowserPage.ts.
  • docs/operations/lazurio-fork-release.md: rows 4 (decision B10), 5, 10, 22, 28 and 30 as above; current /goal references are Orchestrator.ts:6199-6228 and :10241-10270. Stage 3 says to commit row messages with git commit -F <file> --cleanup=verbatim. vp fmt re-aligned the table, so most of its diff is padding.
  • docs/operations/lazurio-overlay.md: a snapshot asked for with fullScreenshot also gets the uncapped capture.
  • .agents/skills/lazurio-upstream-rebuild/SKILL.md: the same commit-message rule.

Row 16's lost line stays in history; it is recorded in #185.

Verification

  • ChatView.logic.test.ts passes 45/45. Mutation: with the old condition the new case fails ("auto" instead of "queue").
  • node --test scripts/lazurio-release-contract.test.mjs passes 51/51. Mutations: without the fullScreenshot line in environmentBrowserConnection.ts, "T3's browser tools reach the Environment browser through their seams" fails; with the old ChatView.logic.ts, "a steer waits behind a turn that waits on the person through its seams" fails.
  • vp run check:changed: format, lint, knip, typecheck, tests (3 files) and react compiler pass. vp fmt --check on the whole repository passes.
  • Allowlist guard emulated: no file outside the allowlist.
  • Codex 0.166.0 codex features list from the linux-x64 archive CodexInstallation.ts names (sha256 checked): default_mode_request_user_input is "under development", off by default and on with -c features.default_mode_request_user_input=true (2026-11-13).
  • Not verified: the servicePreflight hint path at runtime, and the composer change in a browser against a live provider.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e

🤖 Generated with Claude Code

@immakermatty

Copy link
Copy Markdown
Author

Review request: head a7e7725d9c1b9a99ab21154e7e5bb93f859a8c0b.

What changed: the branch was rebased onto main after #196 merged (3846661feb); the commit message is unchanged and the only rebase edit is row 30 of the table in docs/operations/lazurio-fork-release.md, where #196's change and this PR's change are both kept. Lazurio Fork CI is green on this head and the PR is MERGEABLE. Local checks on this head: vp fmt --check clean, node --test scripts/lazurio-release-contract.test.mjs 51/51, ChatView.logic.test.ts 45/45, public-name scan with no new finding.

Please check first:

  1. The condition in planComposerTurn (apps/web/src/components/ChatView.logic.ts:1336-1339): a fresh session now queues during setup for auto as well, and its test in ChatView.logic.test.ts sends a fresh auto and a fresh steer and fails without the fix.
  2. scripts/lazurio-release-contract.test.mjs: the two new pins for decision A2 (lines 2123-2128: the Environment browser passes fullScreenshot, and the host engine returns the full capture for it) and the updated row 30 pin for the new planComposerTurn condition (lines 3317-3321).
  3. Decision B10 in runbook row 4 (upstream's t3 install and launcher protocol hints keep naming upstream's installer).
  4. The -F <file> --cleanup=verbatim instruction in stage 3 of the runbook and in the rebuild skill.

#197 touches the same row 30. If #197 lands first, I will rebase this PR again and say what changed.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e

@agentrozjedemeai

agentrozjedemeai commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

@immakermatty I am handing this PR back to you for the next publication step. Before merge, obtain an independent approval on the current head and check the overlap with the still-open PR #197. Recheck the head and all merge gates after any changes.

At handoff, head a7e7725d9c1b9a99ab21154e7e5bb93f859a8c0b had no review; the four required checks passed and no review threads were unresolved.

Correction: the intake correctly identified you as assigner and agentrozjedemeai as assignee. My earlier statement that those identities were reversed was incorrect; no correction of the intake identity record is needed.

— Pablo

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: žádné nálezy.

Non-blocking: Lokálně prošel cílený test (45/45) a release kontrakt (51/51); format, lint, knip, typecheck a React Compiler prošly. Souhrnná kontrola nemohla spustit prohlížečový test kvůli chybějícímu testovacímu prohlížeči. Fork CI na tomto headu je zelené. Odeslání proti živému poskytovateli ani scénář v prohlížeči jsem neověřil. GitHub nyní hlásí konflikt s main, který je potřeba vyřešit před merge; nový head potřebuje nové review.

— Pablo

…9 check

The independent v0.1.9 check in #185 (points 3 to 7) found:

- Row 30: `planComposerTurn` queued a fresh session during setup only for
  steer and restart, while the runbook said every fresh send queues. A
  fresh "auto" now queues too; the row's test sends a fresh auto and a
  fresh steer, and fails without the fix. The contract pin follows.
- Row 10: decision A2 (full-resolution snapshots) had only a CDP test that
  the fork CI skips. The contract test now pins that the Environment
  browser passes `fullScreenshot` and that `ServerBrowserPage` returns the
  full capture for it. The overlay spec says so next to the 1280 px cap.
- Runbook rows 4 (decision B10: upstream's `t3 install` and launcher
  protocol hints keep naming upstream's installer), 5 (the contract test
  gained the screen-reader pin on v0.1.9), 22 (v0.1.9 context budget and
  the Codex 0.166.0 `features list` check), 28 (`buddySurfaceTimeline.test.ts`)
  and 30 (current `/goal` line references).
- Stage 3 and the rebuild skill: write commit messages to a file and commit
  with `-F <file> --cleanup=verbatim`; the editor cleanup drops lines that
  start with `#`, which lost a wrapped upstream PR reference in row 16.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@immakermatty
immakermatty force-pushed the lazurio/v0.1.9-audit-records branch from a7e7725 to b1cbfc5 Compare November 13, 2026 22:16
@immakermatty

Copy link
Copy Markdown
Author

Rebased onto current main (a622e34fd1, #197 merged) as planned in #197 (comment). New head b1cbfc50b63ee5c674ed22156926091a6005e9ea, replacing the approved a7e7725d9c1b9a99ab21154e7e5bb93f859a8c0b.

What changed against the approved head: only the conflict in docs/operations/lazurio-fork-release.md, row 30, column "Co dělá". Both changes are kept: #197's replacement of "; restart se nemění" with the sentence about restart queueing behind a pending request (decision B9 in #185), and this PR's new Orchestrator.ts line references and closing sentence about a fresh auto send queueing during setup. The table was re-aligned with vp fmt. A whitespace-insensitive row-by-row comparison against both sides shows rows 4, 5, 10, 22 and 28 equal to this PR's previous head, every other row equal to main, and row 30 differing from each side only by the other side's change. Text outside the table is identical to the previous head. The commit message is byte-identical (git commit --amend --cleanup=verbatim -F with the message from git cat-file commit a7e7725d9c).

Local checks on the new head: vp fmt --check clean (7158 files), node --test scripts/lazurio-release-contract.test.mjs 51/51, ChatView.logic.test.ts 45/45, CommandPolicy.test.ts 17/17, lint of the changed code files clean, public-name scan with no new occurrence against main. Typecheck not run locally; the TypeScript in this PR is unchanged from the approved head and Lazurio Fork CI runs it. I will request review on this head once CI is green.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: žádné nálezy.

Non-blocking: Po přenesení na aktuální main zůstává dříve schválená změna logiky stejná. Cílený test prošel 45/45 a release kontrakt 51/51; format, lint, knip, typecheck a React Compiler prošly. Souhrnný test nemohl spustit prohlížečový test kvůli chybějícímu testovacímu prohlížeči. Scénář v prohlížeči ani se živým poskytovatelem jsem neověřil; kontroly GitHubu při review ještě běží.

Agent: environment unknown · bot 893f8471-aa66-4db7-864e-7791c0db5ab0
— Pablo

@immakermatty

Copy link
Copy Markdown
Author

Approved on the exact head b1cbfc50b63ee5c674ed22156926091a6005e9ea (review 5898839514, submitted 2026-11-13T22:19:11Z, after the head commit at 22:15:24Z), with no review threads. Lazurio Fork CI is green on this head (Server and web compatibility, CLI archives linux-x64 and darwin-arm64, Launcher install linux-x64) and the PR is MERGEABLE (CLEAN). The overlap with #197 is resolved: #197 is in main as a622e34fd1 and this head is rebased onto it with both row 30 changes kept (#198 (comment)).

Assigning back to the reviewer to land this in main after rechecking the head and the merge gates.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e

@agentrozjedemeai
agentrozjedemeai merged commit c2d8be0 into main Nov 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants