Conversation
Member
Author
|
Smoke failed with: |
|
Perhaps add |
Member
Author
Yeah, I sometimes add that in temporarily, but normally I prefer the default behavior, to not have to cancel manually. Thanks for the suggestion. |
cclauss
approved these changes
Oct 20, 2024
Member
Author
|
Smoke fails on win32-x86 with: Turns out Node.js 23 removed support of 32-bit Windows (nodejs/node#53184) so I'll restore the |
Member
Author
|
That's fixed. Next issue is that linux-x64 fails with: It's using Python 3.6.8. Need to update (or maybe just rebuild) https://github.com/prebuild/docker-images/blob/master/centos7-devtoolset7/Dockerfile. |
juliangruber
approved these changes
Oct 20, 2024
vweevers
added a commit
to prebuild/docker-images
that referenced
this pull request
Oct 20, 2024
As alternative to centos7-devtoolset7 which: - No longer builds (because mirrorlist.centos.org is offline) - Doesn't support Node.js >= 18 - Doesn't support C++ 20. Ref: prebuild/prebuildify-cross#13 Ref: Level/classic-level#103 (comment)
vweevers
added a commit
to prebuild/docker-images
that referenced
this pull request
Oct 20, 2024
As alternative to `centos7-devtoolset7` which: - No longer builds (because `mirrorlist.centos.org` is offline) - Doesn't support Node.js >= 18 - Doesn't support C++ 20 - Ships an EOL python version (3.6.8) which doesn't work with node-gyp 10 Ref: prebuild/prebuildify-cross#13 Ref: Level/classic-level#103 (comment)
Member
Author
|
That's fixed as well. Smoke now passes, meaning we're ready to release v2 🙂 |
Category: none
Follow-up for c177f3c. Older Electron versions will still work fine, but we stop testing them. Category: removal
Category: none
Previously we used 8.14.0 which is really old. We can't just omit the `--target` argument and use the latest version, because Node.js 23 dropped support of 32-bit Windows. The choice for 18.20.4 specifically is not really important. I just picked LTS and then the latest version within that range. The intent is 18.x. Category: change
Which means classic-level now requires glibc 2.28 (same as Node.js 18) instead of glibc 2.17. Would be a breaking change if an earlier commit didn't already drop support of Node.js < 18. Ref: prebuild/docker-images#38 Category: change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.