Add downloader for R2#711
Merged
Merged
Conversation
pwgardipee
requested review from
Borda,
justusschock,
lantiga and
tchaton
as code owners
tchaton
approved these changes
Sep 10, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
===================================
- Coverage 84% 84% -0%
===================================
Files 52 52
Lines 7200 7277 +77
===================================
+ Hits 6075 6128 +53
- Misses 1125 1149 +24 🚀 New features to boost your workflow:
|
Borda
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will enable downloads from r2. We had a customer report a bug which this fixes (described in video below):
https://www.loom.com/share/4506faf6a3c24179b36643fb090944d5?sid=5f1795f6-f93f-4145-9780-1acda1ab2d2e
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃