feat: Add Python 3.14 zstd builtin support#749
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
===================================
Coverage 80% 80%
===================================
Files 52 52
Lines 7331 7341 +10
===================================
+ Hits 5873 5887 +14
+ Misses 1458 1454 -4 🚀 New features to boost your workflow:
|
deependujha
approved these changes
Nov 6, 2025
Collaborator
deependujha
left a comment
There was a problem hiding this comment.
nice!
In python 3.14, is built-in zstd same as external zstd library?
Collaborator
Author
yes @deependujha. let's see how the test goes with our ci . |
tchaton
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses Python 3.14's built-in
zstdcompression to remove third-party dependency while keeping backward compatibility.ref:
Changes
_PYTHON_GREATER_EQUAL_3_14constant following PyTorch Lightning's naming conventioncompression.zstdfor Python 3.14+ and third-partyzstdfor older versionspython_version < "3.14") in test requirementsPR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃