Fix RichModelSummary model size display#21467
Open
AsherJingkongChen wants to merge 5 commits intoLightning-AI:masterfrom
Open
Fix RichModelSummary model size display#21467AsherJingkongChen wants to merge 5 commits intoLightning-AI:masterfrom
AsherJingkongChen wants to merge 5 commits intoLightning-AI:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21467 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 24059 24005 -54
=========================================
- Hits 20855 18953 -1902
- Misses 3204 5052 +1848 |
bhimrazy
approved these changes
Jan 12, 2026
4a9d305 to
3c49304
Compare
deependujha
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RichModelSummaryincorrectly passedmodel_size(already in MB) toget_human_readable_count(), which converts numbers to K/M/G format. This resulted in misleading output like "5.5 K" instead of the actual size "5,500.000".Now uses
get_formatted_model_size()for consistency withModelSummary.Before submitting
📚 Documentation preview 📚: https://pytorch-lightning--21467.org.readthedocs.build/en/21467/