[FEAT] Remove the need for rebuild after config changes#1528
Merged
[FEAT] Remove the need for rebuild after config changes#1528
Conversation
Collaborator
Repository owner
deleted a comment from
liss-bot
Apr 16, 2024
Owner
Author
|
All ready now! |
Collaborator
@Lissy93 In quick-start.md the port should also be changed to 8080:8080 instead of 8080:80 ? |
This comment was marked as duplicate.
This comment was marked as duplicate.
Owner
Author
|
Oh yeah, you're right, I forgot to update port number in the docs. That should be done now :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
CrazyWolf13
approved these changes
Apr 19, 2024
Collaborator
There was a problem hiding this comment.
@Lissy93 I think here on quick-start.md the port should also be changed to 8080:8080 ?
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big one...
Note
See #1529 for upgrade details
Category: Feature
Overview
/public/conf.ymlto/user-data/...)Issue Number
// TODO: Find and tag related issues
New Vars
N/A
Screenshot
Code Quality Checklist (Please complete)