Prevent Automatic Dosing with Future Glucose#1894
Merged
ps2 merged 7 commits intoLoopKit:devfrom Jan 11, 2023
marionbarker:wip/future-glucose
Merged
Prevent Automatic Dosing with Future Glucose#1894ps2 merged 7 commits intoLoopKit:devfrom marionbarker:wip/future-glucose
ps2 merged 7 commits intoLoopKit:devfrom
marionbarker:wip/future-glucose
Conversation
ps2
requested changes
Jan 9, 2023
Contributor
Author
|
Updated - not sure about translation request. |
Contributor
Author
|
Tests all passed, but I wonder if one should be added to: LoopTests/ViewModels/BolusEntryViewModelTests.swift |
Contributor
Author
|
Added two tests to LoopTests/ViewModels/BolusEntryViewModelTests.swift. |
ps2
reviewed
Jan 10, 2023
Collaborator
ps2
left a comment
There was a problem hiding this comment.
Just noticed a typo, and made an optional name change recommendation.
Contributor
Author
|
All test cases succeeded in Xcode.
|
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
is a work-in-progressPR is in response to Issue #1890.Configuration
Display to User:
Edited to change figure to that displayed with commit: ffbdc46
Debug log message: