Skip to content

Various OmniBLEParser updates and improvements#134

Merged
marionbarker merged 2 commits intoLoopKit:devfrom
itsmojo:OmniBLEParser-updates
Dec 10, 2024
Merged

Various OmniBLEParser updates and improvements#134
marionbarker merged 2 commits intoLoopKit:devfrom
itsmojo:OmniBLEParser-updates

Conversation

@itsmojo
Copy link

@itsmojo itsmojo commented Nov 17, 2024

  • Refactored for more uniform date and time display for all cases
  • New optional -v command line option to enable all print options
  • Enable new pod disconnect/reconnect message printing with -v command line option
  • Enable message address and seq #'s printing with -v command line option
  • Disable new unacknowledged message error printing with -q command line option
  • Disable date printing with timestamps with -q command line option

+ Refactored for more uniform date and time display for all cases
+ New optional -v command line option to enable all print options
+ Enable new pod disconnect/reconnect message printing with -v command line option
+ Enable message address and seq #'s printing with -v command line option
+ Disable new unacknowledged message error printing with -q command line option
+ Disable date printing with timestamps with -q command line option
@marionbarker
Copy link
Collaborator

Status

Success. LGTM.

Testing Overview

This feature is used almost exclusively by @itsmojo as part of his code development and testing.
Apply the modifications and perform minimal testing.

How to use OmniBLEParser:

In Xcode:

  1. Select scheme OmniBLEParser, destination My Mac
  2. Select edit scheme
  3. Add argument: Run, tap + for Arguments Passed on Launch
    • Put full pathname, use quotes if there are any spaces, for file for which parsing is desired

Test with a variety of input files

All these tests were successful.
Used both Xcode 16.1 (for most) tests.
Confirmed Xcode 15.4 also works.

  • Loop Report from main
  • Loop Report from tidepool-merge
  • Trio 0.2.2 log.txt and log_prev.txt files
  • Loop 3.4.4 Xcode Debug log (Xcode 15.4) with metadata on a separate line
  • Loop 3.4.4 Xcode Debug log (Xcode 16.1)
  • Loop tidepool-merge Xcode Debug log (Xcode 16.1)

@marionbarker marionbarker requested a review from ps2 December 6, 2024 00:45
@marionbarker marionbarker merged commit a42a164 into LoopKit:dev Dec 10, 2024
@itsmojo itsmojo deleted the OmniBLEParser-updates branch September 12, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants