Fix GHSA-rvv3-g6hj-g44x: default MaxDepth of 64 for self-referential types (15.x backport)#4619
Merged
jbogard merged 2 commits intorelease/15.xfrom Mar 15, 2026
Merged
Conversation
…ntial types When CheckForCycles auto-enables PreserveReferences for a self-referential reference type, also set MaxDepth=64 (matching System.Text.Json/Newtonsoft.Json defaults) if no explicit limit is configured. This prevents a StackOverflowException DoS when mapping deeply nested distinct object graphs. Also fixes pre-existing .NET 9 build error in MultiThreadingIssues.cs where Array.Reverse() instance method (added in .NET 9, returns void) shadowed the LINQ Reverse() extension method. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Port Azure Key Vault signing, SBOM generation, and OIDC authentication from the main branch release pipeline to the release/15.x branch. Signing and publishing now happen in the Windows job alongside build/test. Linux job retained for cross-platform build verification. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@jbogard Could you please backport of GHSA-rvv3-g6hj-g44x security fix to the |
This was referenced Mar 18, 2026
Contributor
Author
|
@ibakirov We only support the last 2 major versions, all versions prior to 15.x are not supported. The prior versions also don't include code signing certificates, which NuGet would reject now. |
This was referenced Mar 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/15.xlineCheckForCyclesauto-enablesPreserveReferencesfor a self-referential reference type, also setsMaxDepth=64if no explicit limit is configured — matching the default in System.Text.Json and Newtonsoft.JsonMultiThreadingIssues.cs(Array.Reverse()instance method added in .NET 9 shadowed the LINQ extension)Test plan
DeepNestingStackOverflow— maps a 30,000-deep chain without crashing; result truncated at ≤ 64 levelsAssertConfigurationIsValidtest passes (config validation is unaffected)Closes GHSA-rvv3-g6hj-g44x
🤖 Generated with Claude Code