Skip to content

Fail the release when the tag is not on its release branch - #4668

Merged
jbogard merged 2 commits into
mainfrom
ci/verify-release-tag-branch
Oct 26, 2026
Merged

jbogard merged 2 commits into
mainfrom
ci/verify-release-tag-branch

Conversation

@jbogard

@jbogard jbogard commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Before building, the release workflow now checks that the tagged commit is on the right branch: release/<major>.x if that branch exists, otherwise main. If it isn't, the release fails before anything is built, signed or pushed to NuGet.

Why

In #4620, v15.1.1 and v15.1.2 were created through the GitHub Releases UI. Entering the tag name before picking the branch creates the tag on the default branch, so both "15.x" packages were built from 16.x code (main at 1af71bfe). The UI makes this mistake easy to repeat, and nothing in the pipeline caught it.

How

  • The step runs right after checkout in the first release job. The publishing job needs that job, so a failed check stops the release.
  • The tag's major version picks the branch, so v15.* requires release/15.x. If a release/16.x branch is ever created, v16.* tags will then require it automatically.
  • The step uses shell: bash, which also works on the Windows runner.
  • On failure, the error says which branch the tag should be on.

Verification

I ran the same script locally against existing tags:

Tag Result
v15.1.1 ❌ not on release/15.x
v15.1.2 ❌ not on release/15.x
v15.1.3 ✅ on release/15.x
v16.2.0 ✅ on main
v16.0.0-beta-1 ✅ on main

Workflow YAML parses, and job dependencies are unchanged.

Companion PR for release/15.x: #4669

🤖 Generated with Claude Code

A tag created from the GitHub Releases UI can land on the default branch
instead of the selected one, which is how v15.1.1 and v15.1.2 were built
from 16.x code (#4620). Before building, verify the tagged commit is on
release/<major>.x when that branch exists, otherwise on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 22:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T22:13:09.514477Z 0d2699e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Branch lookup errors incorrectly trigger fallback to main, potentially allowing a wrong-branch tag to pass validation.

1 open issue
What changed in this PR

Adds a release-workflow guard to prevent publishing packages from the wrong release branch, addressing the mistagged 15.x releases described in #4620.

Changes:

  • Selects release/<major>.x when it exists, otherwise main.
  • Checks tag ancestry immediately after checkout and stops the release with an error if validation fails.
File Description
.github/​workflows/​release.yml Adds branch selection and tag ancestry validation before building.

Review effort: Balanced

Comment thread .github/workflows/release.yml Resolved
git ls-remote --exit-code returns 2 for no matching refs and 128 for a
failed lookup. Treating any failure as "no release branch" could let a
transient error pass a v15.* tag on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jbogard
jbogard merged commit abe3a67 into main Oct 26, 2026
6 checks passed
@jbogard
jbogard deleted the ci/verify-release-tag-branch branch October 26, 2026 22:18
This was referenced Nov 5, 2026
This was referenced Nov 13, 2026
sondresjolyst pushed a commit to sondresjolyst/garge-api that referenced this pull request Nov 14, 2026
Updated [AutoMapper](https://github.com/LuckyPennySoftware/AutoMapper)
from 16.2.0 to 16.3.0.

<details>
<summary>Release notes</summary>

_Sourced from [AutoMapper's
releases](https://github.com/LuckyPennySoftware/AutoMapper/releases)._

## 16.3.0

## Security

This release fixes two denial-of-service vulnerabilities. In both,
deeply nested input could bypass `MaxDepth` and exhaust the stack. The
resulting `StackOverflowException` can't be caught, so it ends the
process. Please upgrade if your application maps untrusted, deeply
nested data.

-
[GHSA-6vhm-j9h7-f9gh](GHSA-6vhm-j9h7-f9gh):
`MaxDepth` wasn't enforced when mapping through constructor parameters,
including positional records. Thanks to @​mcambria for the report.
-
[GHSA-gpwp-5797-mjff](GHSA-gpwp-5797-mjff):
other recursion paths bypassed `MaxDepth`: derived maps, `object` and
interface members, dictionary and dynamic sources, and recursive type
converters.

CVE IDs have been requested and will be added here once they're
assigned.

## Behavior changes

- Recursion that `MaxDepth` can't limit now throws a catchable
`InsufficientExecutionStackException` instead of crashing the process.
- Derived maps (`Include` / `IncludeBase`) now inherit `MaxDepth` and
get the default limit of 64 for self-referential maps. If your
polymorphic graphs legitimately go deeper, set `MaxDepth` explicitly.
- Constructor mapping now stops at the same depth as property mapping.
- `Condition` on `ForAllMembers`, or any condition whose member
parameter is `object` or a base type, now receives the source member
value instead of the value converted to the destination type, when those
types differ. This matches the documented contract. A `null` in a
nullable source member is now seen as `null` rather than `0` or `false`
(#​4655).

## Other highlights

- Fixed `Context.Items are only available...` exceptions with
`MaxDepth`, which depended on registration or warmup order (#​4651)
- License keys get a 30-day renewal grace period, which logs a warning
instead of an error (#​4667)
- Clearer license validation messages for malformed keys, client
platforms and IdentityModel version mismatches (#​4670)
- Whitespace is stripped from license keys (#​4663), and license
validation is isolated from the host app's `CryptoProviderFactory`
(#​4674)

- ## What's Changed
* Bump Testcontainers.MsSql to 4.14.0 to clear NU1903 by @​jbogard in
LuckyPennySoftware/AutoMapper#4652
* docs: replace dead MyGet build link with CI feed link by @​JiuYue0820
in LuckyPennySoftware/AutoMapper#4648
* Emit the context check for the containing type map in CollectionMapper
(fixes #​4650) by @​jbogard in
LuckyPennySoftware/AutoMapper#4651
* Pass the source member value to Condition by @​jbogard in
LuckyPennySoftware/AutoMapper#4655
* Fix licensing page structure in docs ToC by @​jbogard in
LuckyPennySoftware/AutoMapper#4664
* Fix BuildDateUtc embedding on Windows builds by @​jbogard in
LuckyPennySoftware/AutoMapper#4666
* License validation: WARNING during the renewal grace period by
@​jbogard in LuckyPennySoftware/AutoMapper#4667
* Fail the release when the tag is not on its release branch by
@​jbogard in LuckyPennySoftware/AutoMapper#4668
* ci: bump lock-threads to v6 to fix token validation failure by
@​simpleqt in LuckyPennySoftware/AutoMapper#4658
* Strip whitespace from license keys before resolving precedence by
@​AVTUNEY in LuckyPennySoftware/AutoMapper#4663
* License validation: clear messages for malformed keys, client
platforms, and IdentityModel version mismatches by @​jbogard in
LuckyPennySoftware/AutoMapper#4670
* Move to central package management by @​jbogard in
LuckyPennySoftware/AutoMapper#4672
* License validation: isolate from the host app's CryptoProviderFactory
by @​jbogard in
LuckyPennySoftware/AutoMapper#4674
* Replace broken ApiCompat setup with SDK package validation by
@​jbogard in LuckyPennySoftware/AutoMapper#4673
* Add regression test for registration-order MaxDepth context failure by
@​jbogard in LuckyPennySoftware/AutoMapper#4675
* Document license key environment variables in the README by @​jbogard
in LuckyPennySoftware/AutoMapper#4677

## New Contributors
* @​JiuYue0820 made their first contribution in
LuckyPennySoftware/AutoMapper#4648
* @​simpleqt made their first contribution in
LuckyPennySoftware/AutoMapper#4658
* @​AVTUNEY made their first contribution in
LuckyPennySoftware/AutoMapper#4663

**Full Changelog**:
LuckyPennySoftware/AutoMapper@v16.2.0...v16.3.0

Commits viewable in [compare
view](LuckyPennySoftware/AutoMapper@v16.2.0...v16.3.0).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=AutoMapper&package-manager=nuget&previous-version=16.2.0&new-version=16.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/sondresjolyst/garge-api/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants