Skip to content

Hey, I made some changes. Can you review and maybe add them to your project?#98

Open
Rahulfordev wants to merge 2 commits intoLukasLen:masterfrom
Rahulfordev:feat/time-based-blur
Open

Hey, I made some changes. Can you review and maybe add them to your project?#98
Rahulfordev wants to merge 2 commits intoLukasLen:masterfrom
Rahulfordev:feat/time-based-blur

Conversation

@Rahulfordev
Copy link

Feature: Time-Based Blur
This PR introduces a feature that automatically enables/disables the blur effect based on a user-defined time range (e.g., office hours).

Why it's useful:

  • Allows users to automate the blur without manually toggling it.
  • Ensures better productivity during working hours.

How it works:

  • The user sets a start and end time in the settings.
  • The extension checks every 30 seconds if the current time is within that range.
  • Blur is applied or removed accordingly.

Let me know if any improvements are needed!

@aryomuzakki
Copy link
Collaborator

The time-based blur idea is really cool.

I tried checking out the commit, but unfortunately it’s not working. There’s an error in the way it is toggled.

And I think instead of manually applying and removing the blur, it will be simpler and better to just toggle the extension on or off, since the extension already listens for browser.storage changes in contentScript.js line 160.

Also, this is just passing thought, I think it will also better to just set timeout to turn on and turn off instead of checking per interval. It will remove any timeout only when Time-Based blur are inactive. And start counting again when active, doesn't matter if the main extension toggle active or not.

If you're up for tweaking the code and make it work, I think it could be a really nice upgrade of this extension.
Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants