Re-enabled installation of VSBuild tools for ComfyUI-Zluda#1444
Re-enabled installation of VSBuild tools for ComfyUI-Zluda#1444mohnjiles merged 3 commits intoLykosAI:mainfrom
Conversation
…ptionals for ComfyUI-Zluda install
Summary of ChangesHello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the installation experience for ComfyUI-Zluda by automating the setup of Visual Studio Build Tools. By re-enabling and precisely configuring the installation of these critical C++ development tools, the change eliminates a common manual step that often led to installation failures, ensuring that the Triton module can be built successfully and streamlining the overall user onboarding process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly enables the automatic installation of Visual Studio Build Tools for ComfyUI-Zluda, which is a great improvement for the user experience. The changes properly update the prerequisites and user-facing text to reflect this. I've added a couple of suggestions to improve code readability and maintainability, and to fix a minor text formatting issue.
Added VcBuildTools to ComfyZluda Prerequisites - Modified ComfyZluda.cs to include PackagePrerequisite.VcBuildTools in the prerequisites list and re-enabled automatic VcBuildTools Installation during ComfyUI-Zluda install by uncommenting the VcBuildTools installation check in WindowsPrerequisiteHelper.cs and include specific required optionals.
Updated both the Disclaimer and AdminRequiredReason properties to reflect that VS Build Tools will be installed automatically.
This will prevent the need for the user to manually install Visual Studio Build Tools for C++ Desktop Dev., as required by ComfyUI-Zluda. Since it will result in generation failure if the user unknowingly does not install it on their system, as it is a required dependency to build the Triton module for their install.
Also added notice that the install process may take several minutes to complete as the unattended VSBuildTools installation does take a bit of time to complete and will look like it hanged before finishing.