Skip to content

Re-enabled installation of VSBuild tools for ComfyUI-Zluda#1444

Merged
mohnjiles merged 3 commits intoLykosAI:mainfrom
NeuralFault:comfyui-zluda-vsbuild
Oct 27, 2025
Merged

Re-enabled installation of VSBuild tools for ComfyUI-Zluda#1444
mohnjiles merged 3 commits intoLykosAI:mainfrom
NeuralFault:comfyui-zluda-vsbuild

Conversation

@NeuralFault
Copy link
Contributor

Added VcBuildTools to ComfyZluda Prerequisites - Modified ComfyZluda.cs to include PackagePrerequisite.VcBuildTools in the prerequisites list and re-enabled automatic VcBuildTools Installation during ComfyUI-Zluda install by uncommenting the VcBuildTools installation check in WindowsPrerequisiteHelper.cs and include specific required optionals.

Updated both the Disclaimer and AdminRequiredReason properties to reflect that VS Build Tools will be installed automatically.

This will prevent the need for the user to manually install Visual Studio Build Tools for C++ Desktop Dev., as required by ComfyUI-Zluda. Since it will result in generation failure if the user unknowingly does not install it on their system, as it is a required dependency to build the Triton module for their install.

Also added notice that the install process may take several minutes to complete as the unattended VSBuildTools installation does take a bit of time to complete and will look like it hanged before finishing.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the installation experience for ComfyUI-Zluda by automating the setup of Visual Studio Build Tools. By re-enabling and precisely configuring the installation of these critical C++ development tools, the change eliminates a common manual step that often led to installation failures, ensuring that the Triton module can be built successfully and streamlining the overall user onboarding process.

Highlights

  • Automatic VS Build Tools Installation: Re-enabled the automatic installation of Visual Studio Build Tools for ComfyUI-Zluda, preventing the need for manual user intervention.
  • Prerequisite Management: Added VcBuildTools to the list of required prerequisites for ComfyZluda packages.
  • Specific Component Installation: Updated the VcBuildTools installation command to include a comprehensive set of specific components and Windows SDKs, ensuring all necessary dependencies are met.
  • User Communication: Modified the Disclaimer and AdminRequiredReason properties to inform users about the automatic installation of VS Build Tools and the potential duration of the process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly enables the automatic installation of Visual Studio Build Tools for ComfyUI-Zluda, which is a great improvement for the user experience. The changes properly update the prerequisites and user-facing text to reflect this. I've added a couple of suggestions to improve code readability and maintainability, and to fix a minor text formatting issue.

@mohnjiles mohnjiles merged commit dc91cc4 into LykosAI:main Oct 27, 2025
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
@NeuralFault NeuralFault deleted the comfyui-zluda-vsbuild branch October 27, 2025 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants