v2.15.4 #1449
v2.15.4 #1449
Conversation
Downmerg from public
…into downmerg-from-public-again
Downmerg from public again
Fix swarm missing dotnet env vars, update civitai early access … (cherry picked from commit 51fbd43202c78199f6420f4b6a893579d526f087)
[dev to main] backport: Fix swarm missing dotnet env vars, update civitai early access … (1173)
Summary of ChangesHello @mohnjiles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a maintenance release focused on improving user experience and system stability. Key updates include enhanced visibility for Early Access content and clearer error messaging within Civitai integration, alongside significant bug fixes for package installations and environment synchronization. The introduction of a Python version selector in the Package Import dialog also provides greater control over package dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new version with several valuable features and bug fixes, such as an improved package import dialog with a Python version selector and better error handling for Civitai downloads. The changes are generally well-implemented. I've identified a high-severity issue regarding a potentially breaking change in package prerequisites, a medium-severity issue related to inconsistent fallback logic, and a minor correction for the changelog.
| public virtual IEnumerable<PackagePrerequisite> Prerequisites => | ||
| [ | ||
| PackagePrerequisite.Git, | ||
| PackagePrerequisite.Python310, | ||
| PackagePrerequisite.VcRedist, | ||
| PackagePrerequisite.VcBuildTools, | ||
| ]; | ||
| [PackagePrerequisite.Git, PackagePrerequisite.Python310, PackagePrerequisite.VcRedist]; |
There was a problem hiding this comment.
Removing PackagePrerequisite.VcBuildTools from the default Prerequisites list is a potentially breaking change. Any package that inherits from BasePackage and requires VcBuildTools but does not override this property will now fail to have this prerequisite installed. If this change is intentional, please ensure all dependent packages have been updated to explicitly include VcBuildTools in their Prerequisites. Otherwise, it should be added back to prevent installation failures.
| - Updated Package Import dialog to have Python version selector | ||
| ### Fixed | ||
| - Fixed [#1435](https://github.com/LykosAI/StabilityMatrix/issues/1435) - SwarmUI not launching due to missing dotnet | ||
| - Fixed various install and Inference issues with ComfyUI-Zluda - big thanks to @neural_fault for the PRs! |
There was a problem hiding this comment.
There seems to be a typo in the contributor's username. The pull request description mentions @NeuralFault, but the changelog has @neural_fault. For consistency and to ensure proper credit, it would be best to use the casing from the PR description.
| - Fixed various install and Inference issues with ComfyUI-Zluda - big thanks to @neural_fault for the PRs! | |
| - Fixed various install and Inference issues with ComfyUI-Zluda - big thanks to @NeuralFault for the PRs! |
| SelectedPythonVersion = | ||
| GetRecommendedPyVersion() ?? AvailablePythonVersions.FirstOrDefault(); |
There was a problem hiding this comment.
There's a small inconsistency in the fallback logic for selecting a Python version. Here, FirstOrDefault() is used, while OnLoadedAsync uses LastOrDefault(). Using LastOrDefault() is preferable as it will select the latest available patch version of Python if a recommended version isn't found. For consistency and to provide a better default, I suggest using LastOrDefault() here as well.
SelectedPythonVersion =
GetRecommendedPyVersion() ?? AvailablePythonVersions.LastOrDefault();
2 participants
Changed
Fixed
Supporters
🌟 Visionaries
Our heartfelt thanks to the driving force behind our progress, our Visionaries: Waterclouds, JungleDragon, bluepopsicle, Bob S, and whudunit! Your incredible support is the fuel that powers our development, allowing us to tackle bugs and push forward with confidence.
🚀 Pioneers
A huge shoutout to our amazing Pioneers, who keep the momentum going strong! Thank you for being our trusted crew on this journey: Szir777, Noah M, USATechDude, Thom, SeraphOfSalem, Desert Viber, Tundra Everquill, Adam, Droolguy, Philip R., ACTUALLY_the_Real_Willem_Dafoe, takyamtom, and robek!