More lenient loading of block entities#210
Open
pishleback wants to merge 1 commit intoMCHPR:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the plot crashing when
//loading schematics I'd saved on ORE and downloaded via schemati. I've made the loading of the block entity nbt data more lenient so that it more leniently handles the format used in the schematic I was trying to load. It was failing before this edit because the field was calledcountrather thanCountand the type wasIntrather thanByte. I've made a similar change too for theSlotfield, though it was not that field causing me problems.