Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
05ce100
refactor: move inferring code to separate module
cbouy Sep 29, 2023
3c54557
add docs stub
cbouy Sep 29, 2023
75be6d3
refactor as a class
cbouy Sep 29, 2023
1a2d0c5
add template based inferring
cbouy Sep 29, 2023
ff8bb18
handle deprecate NoImplicit
cbouy Dec 14, 2023
a89a193
fix tests and add missing TemplateInferer tests
cbouy Dec 14, 2023
214dc05
formatting and typing
cbouy Dec 14, 2023
b926b91
remaining formating issues and docs
cbouy Dec 15, 2023
c2cb076
add adjust_hydrogens to TemplateInferer
cbouy Dec 15, 2023
7e76f73
improve test coverage
cbouy Dec 15, 2023
189ed17
more nitpicks
cbouy Dec 15, 2023
573a8d1
add rdDetermineBonds inferer
cbouy Dec 16, 2023
e987fdb
address comments and linting
cbouy Apr 1, 2024
5cbc9d0
revert auto-formatting
cbouy Apr 1, 2024
cf4c38d
expose STANDARDIZATION_REACTIONS and MONATOMIC_CATION_CHARGES for bac…
Aug 23, 2024
a5caf76
make sanitization optional
cbouy Aug 23, 2024
7adaa02
fix rdkit support for numpy v2
cbouy Aug 23, 2024
5ff8f47
fix tests
cbouy Aug 24, 2024
3a05f2b
document usage of rdkit inferers
cbouy Aug 24, 2024
454c0d5
fix remaining tests rdkit incompatible with numpy 2
cbouy Aug 24, 2024
31964b4
Merge branch 'develop' into rdkit-converter-inferring
cbouy Aug 26, 2024
ac4a6c0
Merge branch 'develop' into rdkit-converter-inferring
cbouy Jul 3, 2025
12d7ca4
chore: formatting/linting
cbouy Jul 3, 2025
076e06f
address comments: bump to 2.10.0, fix docs, formatting, missing tests
cbouy Jul 4, 2025
add0def
chore: rename to inferrer
cbouy Jul 4, 2025
8dd3df1
formatting
cbouy Jul 4, 2025
22f4b1e
fix failing tests
cbouy Jul 4, 2025
83a4674
Merge branch 'develop' into rdkit-converter-inferring
cbouy Jul 14, 2025
3cfb60a
Merge branch 'develop' into rdkit-converter-inferring
cbouy Jul 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-deps/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ inputs:
pytng:
default: 'pytng>=0.2.3'
rdkit:
default: 'rdkit>=2020.03.1'
default: 'rdkit>=2024.03.4' # supports both numpy v1 and v2
scikit-learn:
default: 'scikit-learn'
seaborn:
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
networkx
parmed
pytng>=0.2.3
rdkit>=2020.03.1
rdkit>=2024.03.4
tidynamics>=1.0.0
# remove from azure to avoid test hanging #4707
# "gsd>3.0.0"
Expand Down
10 changes: 9 additions & 1 deletion package/CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ The rules for this file:
-------------------------------------------------------------------------------
??/??/?? IAlibay, orbeckst, BHM-Bob, TRY-ER, Abdulrahman-PROG, pbuslaev,
yuxuanzhuang, yuyuan871111, tanishy7777, tulga-rdn, Gareth-elliott,
hmacdope, tylerjereddy
hmacdope, tylerjereddy, cbouy


* 2.10.0
Expand All @@ -40,6 +40,8 @@ Fixes
directly passing them. (Issue #3520, PR #5006)

Enhancements
* Added `TemplateInferrer` and `RDKitInferrer` dataclasses to the
`RDKitInferring` module to be used by the RDKit converter. (PR #4305)
* Improve speed of GROMOS11 (TRC) reader (Issue #5079, PR #5080)
* Improve parsing of topology information from LAMMPS dump files to allow
reading of mass, charge and element attributes. (Issue #3449, PR #4995)
Expand All @@ -63,11 +65,17 @@ Enhancements
MDAnalysisTest.util (PR #5038)

Changes
* Refactored the RDKit converter code to move the inferring code in a separate
`RDKitInferring` module. The bond order and charges inferrer has been move to
an `MDAnalysisInferrer` dataclass in there. (PR #4305)
* Removed undocumented and unused attribute
`analysis.lineardensity.LinearDensity.totalmass` (PR #5007)
* Remove `default` channel from RTD conda env. (Issue # 5036, PR # 5037)

Deprecations
* The RDKit converter parameter `NoImplicit` has been deprecated in favour of
`implicit_hydrogens` and `inferrer` parameters. `max_iter` has been moved
under `MDAnalysisInferrer`. (PR #4305)


03/11/25 IAlibay, ChiahsinChu, RMeli, tanishy7777, talagayev, tylerjereddy,
Expand Down
Loading
Loading