Update deploy things for py312 + OpenID Connect publishing#4325
Update deploy things for py312 + OpenID Connect publishing#4325
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4325 +/- ##
==========================================
Coverage 93.37% 93.37%
==========================================
Files 170 184 +14
Lines 22295 23403 +1108
Branches 4075 4075
==========================================
+ Hits 20818 21853 +1035
- Misses 962 1035 +73
Partials 515 515 ☔ View full report in Codecov by Sentry. |
|
OpenID Connect trusted publisher for test and normal PyPi have now been set for MDAnalysis and MDAnalysisTests |
|
For the sake of security, all old API tokens have also been deleted. |
orbeckst
left a comment
There was a problem hiding this comment.
I hope it works! Thanks for the update.
(Small question about including "develop" but I assume that this fine.)
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_API_TOKEN_SRC }} | ||
| uses: pypa/gh-action-pypi-publish@v1.18.10 |
There was a problem hiding this comment.
Is the MDA deployment so complicated that we can't use our action https://github.com/MDAnalysis/pypi-deployment ?
There was a problem hiding this comment.
cibuildwheels deployments don't work via pypi-deployment right now - that's a bit more complicated so I've not added that branch yet (it's a bit more messy because you usually want to parallelise at the level of runners for each flavour you build wheels for - you don't fully have to though, you can just trust the docker container to get it right).
One day I'll get that done, it's just not been a burning priority (although the amount of cython packages we're maintinaing is starting to grow).
What I can't stuff in a reusable action though is the arm builds (using Cirrus), those will need to exist everywhere we need those builds (currently just here).
There was a problem hiding this comment.
Extra info for anyone reading this and going "but why cibuildwheels here and not everywhere else" (it's a recurring question we should document) - we use cibuildwheels to build anything that can't do a pure Python wheel (i.e. uses Cython).
There was a problem hiding this comment.
Do we have a "maintainer FAQ" somewhere — wiki or NF drive?
There was a problem hiding this comment.
Unfortunately not, we have barbones deployment docs on the userguide but yeah there's just not been enough of my time to add docs for everything - that's what we applied for that SDG for though so fingers crossed!
Towards #4326
Title says it all
Changes made in this Pull Request:
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4325.org.readthedocs.build/en/4325/