Add Py3.12 for Azure pipelines CI#4327
Merged
tylerjereddy merged 2 commits intodevelopfrom Oct 30, 2023
Merged
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Member
Author
|
This will take some time to fix everything - current hold up is pytng's upcoming py3.12 release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4327 +/- ##
==========================================
Coverage 93.37% 93.37%
==========================================
Files 170 184 +14
Lines 22295 23403 +1108
Branches 4075 4075
==========================================
+ Hits 20818 21853 +1035
- Misses 962 1035 +73
Partials 515 515 ☔ View full report in Codecov by Sentry. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Seems good to go. |
tylerjereddy
approved these changes
Oct 30, 2023
Member
tylerjereddy
left a comment
There was a problem hiding this comment.
LGTM, I spot checked the log output in one of the new 3.12 jobs, and we still have 3.11 tested elsewhere in our overall matrix, so in it goes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably going to fail, but let's at least try.
Changes made in this Pull Request:
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4327.org.readthedocs.build/en/4327/