Merged
Conversation
Game Test Results✅ Success
Workflow run: #421 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing language entries for items implemented as ItemNameBlockItem (which were previously excluded from item translation generation).
Changes:
- Update
MiaLangProviderto includeItemNameBlockIteminstances when generating item translations. - Regenerate
en_us.jsonto include new item names (e.g.,dream_lichee,gloom_berry). - Regenerate an item tag JSON (ordering change in
artifact_modifiers_material.json).
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/java/com/altnoir/mia/datagen/MiaLangProvider.java |
Adjusts item filtering so ItemNameBlockItem gets item.* translations generated. |
src/generated/resources/data/mia/tags/item/artifact_modifiers_material.json |
Regenerated tag values (order changed). |
src/generated/resources/assets/mia/lang/en_us.json |
Regenerated lang file adding missing item entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.