Conversation
* cast file path to str before checking extension * fixup! cast file path to str before checking extension
* revamp linting makefile, avoid pipes, track RCs and exit with total * set bash in makefile, use NUL delimiters, keep KO as bool * echo before shellchecking
* sort dataset by shot/time, log time for concat/sortby * sort only if those coords are present * similarly apply sortby when testing * fix arg for sortby * fixup! fix arg for sortby
* dump config from get_shots_data * add filter_dict to utils.misc * do not dump password into config json * drop attributes and tests sections before json dump * do not hide config dump * simplify typing by dropping Any * change wording of filter_dict * upgrade config dump to verbose
* mention xarray next to mdsplus in concept section * add JOSS paper badge * update JOSS paper status, add link * add citation file * remove journal abbreviations * mention Xarray in workflow section, too
* Update REFERENCES.md with new conference details Added references for the 6th Fusion HPC Workshop and updated existing references. * whitespace * drop abstract --------- Co-authored-by: gtrevisan <gtrevisan@users.noreply.github.com>
* mention mdsplus vs apple silicon * rephrase explanation of data sources * rephrase instructions about prereq in INSTALL.md
Contributor
There was a problem hiding this comment.
Pull request overview
Release prep for v0.14, bundling several framework fixes (path handling, deterministic output ordering, config dumping), automation/linting improvements, and documentation/citation updates.
Changes:
- Improve workflow reproducibility and determinism (dump config, sort concatenated dataset by shot/time).
- Fix
FileShotlistSettingto handlePath-like inputs for extension checks. - Refresh docs/references/citation metadata and tighten Makefile lint target error propagation.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_output_setting.py |
Updates assertions to account for sorted concatenation behavior. |
pyproject.toml |
Bumps version and adds toml-sort override for validity range formatting. |
makefile |
Ensures bash is used and makes lint targets propagate failures correctly. |
disruption_py/workflow.py |
Adds JSON configuration dump for reproducibility. |
disruption_py/settings/shotlist_setting.py |
Makes parquet extension detection robust to Path inputs. |
disruption_py/settings/output_setting.py |
Adds concat timing logs and sorts dataset outputs by shot,time when available. |
disruption_py/settings/__init__.py |
Minor import formatting consolidation. |
disruption_py/core/utils/misc.py |
Adds filter_dict helper for config sanitization before dumping. |
REFERENCES.md |
Updates publication/conference reference entries. |
README.md |
Updates project description, adds testing/linting snippets, updates citation details. |
INSTALL.md |
Clarifies prerequisite guidance and adds Apple Silicon note for MDSplus. |
CITATION.cff |
Adds GitHub-recognized citation metadata file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crea-psfc
approved these changes
Mar 19, 2026
yumouwei
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework
Automation
Documentation
Dependencies