Allow reading from config.json for matrix command line flags#702
Merged
Conversation
ty-porter
commented
Apr 2, 2026
| "format" | ||
| ], | ||
| "patternProperties": { | ||
| "^\\$schema$": { "type": "string" } |
Contributor
Author
There was a problem hiding this comment.
All the tooling around this is brittle because the keywords are colliding... This is the best solution I could come up with.
WardBrian
reviewed
Apr 2, 2026
ty-porter
force-pushed
the
700-config-matrix-options
branch
from
b435084 to
a0ece15
Compare
WardBrian
reviewed
Apr 3, 2026
ty-porter
force-pushed
the
700-config-matrix-options
branch
from
e788aa8 to
1b9f864
Compare
WardBrian
approved these changes
Apr 3, 2026
WardBrian
left a comment
WardBrian
left a comment
Member
There was a problem hiding this comment.
I'm not able to try it out locally atm, but reading over the changes I think this is good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #700
Adds ability to read from a config file
matrixsubsection for the CLI flags. This is more complex than it sounds due to 1) a circular dependency on CLI read vs. config instantiation and 2) tests also reading command line flags implicitlyWe read flags in 2 passes. The first pass picks up
--configif it exists. This lets a new config object read the values inmatrixand pass it back to the parser which uses those values as default.The priority of flags is user-specified CLI flags > JSON config flags > argparse defaults
updated and the config validator is expanded to completely ignore the
matrixsubkeys when removing keys. It still adds the section overall if it is missing.