chore: add road transport to airport or to port

[cedricr]

🔧 Problem

Fix #1778

See also: MTES-MCT/ecobalyse-data#211

🍰 Solution

Updates the countries.json file with values for distances to port and airport. The new format is

  {
    "aquaticPollutionScenario": "Best",
    "averageDistanceToAirport": 500,
    "averageDistanceToPort": 500,

🚨 Points to watch/comments

This should not be merged until the frontend is ready!

[cedricr]

Note : I have to fix the prettier issue (this file should not be checked by prettier, as it is formatted on the data side

[n1k0]

LGTM, client needs to be updated to consume this new format, I'll do that on top of this branch

[n1k0]

@cedricr build is failing with a json formatting issue you might want to fix before I take over the patch :)

[warn] Code style issues found in the above file. Run Prettier with --write to fix.

Edit: damn missed your comment about this, scratch my comment

[cedricr]

@paulboosz I’ve fixed the prettier issue, but maybe we should consider excluding all the public/data folder, instead of adding all its files one by one 😅. Or, if some of the files inside are not coming from the data repo, establish a clearer separation.

[cedricr]

@nicolaspkandeel looks good to you too ? We can even add other transportation means later on (rail, etc.)

{
      "air": {
        "byPlane": 500,
        "byTruck": 500
      },
      "road": 500,
      "sea": {
        "byBoat": null,
        "byTruck": null
      }
}

[cedricr]

@cedricr build is failing with a json formatting issue you might want to fix before I take over the patch :)

[warn] Code style issues found in the above file. Run Prettier with --write to fix.

Edit: damn missed your comment about this, scratch my comment

@n1k0 the prettier problem is fixed, but the tests fails, which… is expected for now I guess.

[n1k0]

@n1k0 the prettier problem is fixed, but the tests fails, which… is expected for now I guess.

Indeed, I'll take over from there 👍

[nicolaspkandeel]

@nicolaspkandeel looks good to you too ? We can even add other transportation means later on (rail, etc.)

{
      "air": {
        "byPlane": 500,
        "byTruck": 500
      },
      "road": 500,
      "sea": {
        "byBoat": null,
        "byTruck": null
      }
}

Looks like there is only 500km truck in this config, not 1000 (500km in the country of departure + 500km in the country of arrival). For transport within a country it is fine (there is a rule to refuse the distance for very small distance) but not in other situations.

It would be more intuitive to me to have the 500km as a parameter attached to a country/région, and not directly written in the table of distances.
Thus the total transport would be (for sea transport) 1+2+3:

1. internal transport by Truck in région of origin
2. Distance by boat between the two régions
3. Internal transport by Truck in région of destination

Did you considered this option ?
NB I guess such a distance could also be used as the distance for "distribution"

Then, I see that the distances with unknown region is still defined here, whereas it is a default value. It is confusing. If there is a good reason for that just ignore this last comment.

[cedricr]

It would be more intuitive to me to have the 500km as a parameter attached to a country/région, and not directly written in the table of distances. Thus the total transport would be (for sea transport) 1+2+3:
(…)
Did you considered this option ? NB I guess such a distance could also be used as the distance for "distribution"

@nicolaspkandeel Excellent points ! I’ll migrate the values to the countries file.

[cedricr]

@nicolaspkandeel I’ve added

    "averageDistanceToAirport": 500,
    "averageDistanceToPort": 500,

to each country. We can talk later on about how to get a more precise estimate.

@n1k0 works for you?

[n1k0]

Woah for some reason I missed I was tagged with an open question asked, sorry! The latest changes to the format looks good and I feel like countries.json file is indeed the right place to have country-specific internal transportation distances information defined and handled. So, that works for me!

I'm taking over the branch and will implement #1531 right here.